fix: remove trailing slash from PUBLIC_PATH env var #154
Conversation
|
Hi Dave! Thanks for the PR. Does this change fix a particular issue, or is it just a cosmetic change? |
|
@regisb if this change gets in it should remove the need to add extra trailing slash handling logic in |
|
I have no idea what's going on and I should never have asked 😅 passing it on to you @arbrandes! I'd just like to ask that you create a changelog entry with |
We previously generated the PUBLIC_PATH base for each MFE with a trailing slash, e.g. "/authn/". But the actual links that point to these from the LMS and Studio don't have a trailing slash in them, e.g. "/authn". This commit removes the trailing slash to be consistent. Removing that trailing slash in configuration also means that we don't have to strip it out on the JavaScript side of things, which would have been necessary after the React Router 6 upgrade (we send it as the router's basename).
ormsbee
force-pushed
the
remove-trailing-slash
branch
from
510ef94
to
2dce48d
Compare
We previously generated the PUBLIC_PATH base for each MFE with a trailing slash, e.g. "/authn/". But the actual links that point to these from the LMS and Studio don't have a trailing slash in them, e.g. "/authn". This commit removes the trailing slash to be consistent.